Conversation
Collaborator
Author
|
@cpaulgilman I'll do some more testing on the RC, but for now these changes seemed to work well in the editor and in generating the pdfs. Most of my testing was for marine as that was the one that needed the most updates. We also have some patch issues for continued report improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Update monthly energy print checking for basic report (all technologies except IPH ones, remove retired technologies from check)
-Updates to marine energy report to allow it to work for wave and tidal, SO and LCOEFCR, + different converter and resource definition options
-Minor update to marine variable name for tidal turbine design feature
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.